Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NTF to new pipeline #106

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

nevelis
Copy link

@nevelis nevelis commented Jul 28, 2020

Network token function added to the new pipeline & configuration, with a single in/out gate on the NTF module.

If NTF is enabled in sim mode, 1000/5000 flows will have tokens, with roughly 1/6th of the packets being a STUN packet with a network token in it. This is not a realistic scenario - in practice there will be far less network token packets being sent, but given the limitations of the Source module and Rewrite module (32 packet templates max), this is the best we can do for the least effort that verifies things are working.

@omecproject
Copy link

Can one of the admins verify this patch?

2 similar comments
@omecproject
Copy link

Can one of the admins verify this patch?

@omecproject
Copy link

Can one of the admins verify this patch?

@krsna1729
Copy link
Member

Test this please

@nevelis nevelis force-pushed the upf-bess-ntf branch 5 times, most recently from fba40d2 to 79eef4b Compare July 28, 2020 04:26
@krsna1729
Copy link
Member

squash and rebase

@krsna1729
Copy link
Member

@nevelis it did not seem to have rebased correctly
image

If in mode="sim" and enable_ntf is set, ~1000 clients will have ~1/6th
of their packets will have a network token.

This is not a very realistic test in the real world, but it is enough to
validate that all the bits are working.
@nevelis
Copy link
Author

nevelis commented Jul 30, 2020

@krsna1729 I think it's rebased correctly now but it's failing on container push. Is there anything I need to do here?

@yoooou
Copy link

yoooou commented Jul 30, 2020

retest this please

@krsna1729
Copy link
Member

krsna1729 commented Jul 30, 2020

it's failing on container push. Is there anything I need to do here?

Same reason as before - we dont have a bot yet and you dont have write creds for this repo

@krsna1729
Copy link
Member

@nevelis there is no change in upf.json can you remove from the PR?

@nevelis
Copy link
Author

nevelis commented Jul 31, 2020

@nevelis there is no change in upf.json can you remove from the PR?

The change to upf.json fixes the inconsistent use of leading tabs & spaces for indentation which was triggering me due to my different indentation settings :) I can revert this though, what do you think?

@krsna1729
Copy link
Member

that must be somebody's emacs :P
Lets have it in the PR. thanks!

@krsna1729 krsna1729 merged commit 0f6188f into omec-project:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants