Add changes to make UPF-EPC work in K8S environment #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krsna1729
reviewed
Mar 18, 2020
krsna1729
reviewed
Mar 18, 2020
krsna1729
reviewed
Mar 18, 2020
krsna1729
approved these changes
Mar 18, 2020
ajamshed
reviewed
Mar 18, 2020
| @@ -50,6 +50,8 @@ def scan_dpdk_ports(): | |||
| else: | |||
| raise | |||
| idx += 1 | |||
| if idx == 30: | |||
There was a problem hiding this comment.
Any reason why the idx check is hard-coded till 30?
There was a problem hiding this comment.
Hmm.....I'll include it to my patch.
ajamshed
approved these changes
Mar 18, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.