Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize capabilities, emulate k8s env closely with pause #68

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

krsna1729
Copy link
Member

@krsna1729 krsna1729 commented Jun 12, 2020

  1. Added pause container using which all routes and interfaces are setup with higher privileges (NET_ADMIN)
  2. DPDK 19.11 introduced return codes for pmd promiscuous callbacks, Introduce knob in BESS to explicitly enable promiscuous and ignore dev_start permission error

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729 krsna1729 requested a review from ajamshed June 12, 2020 05:08
@krsna1729
Copy link
Member Author

rte_eth_dev_start -> rte_eth_dev_config_restore
In 19.11 DPDK started returning errors
DPDK/dpdk@9039c81
DPDK/dpdk@69d0e70

Gist
https://gist.github.com/krsna1729/0c7160920343f9fa55f760c770286155

So we check if the error was permission issue we ignore it. This allows
us to operate without NET_ADMIN

Signed-off-by: Saikrishna Edupuganti saikrishna.edupuganti@intel.com

@krsna1729
Copy link
Member Author

/cc @hyunsun

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@ajamshed ajamshed merged commit 16a97ab into master Jun 12, 2020
@krsna1729 krsna1729 deleted the remove-net-admin branch June 17, 2020 01:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants