Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to PTF framework #805

Merged
merged 3 commits into from
May 6, 2024
Merged

Improvements to PTF framework #805

merged 3 commits into from
May 6, 2024

Conversation

gab-arrobo
Copy link
Collaborator

This PR does the following:

  • Add GHA for building PTF Docker image
  • Refactor ptf/Dockerfile and move to use a newer Ubuntu version
  • Consolidate variables (i.e., MAC addresses) for the different linerate tests into a single file (common.py)
  • Increase wait time time.sleep(DURATION) for the qos_metrics.my tests such that all packets are received
  • Update README.md documentation

@gab-arrobo gab-arrobo requested a review from amarsri28 May 2, 2024 18:21
@gab-arrobo gab-arrobo changed the title Improve PTF framework Improvements to PTF framework May 3, 2024
sureshmarikkannu
sureshmarikkannu reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@sureshmarikkannu sureshmarikkannu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have tested the patch and all tests works fine. I have added one minor comment about sample config to be used.

@gab-arrobo
Copy link
Collaborator Author

i have tested the patch and all tests works fine. I have added one minor comment about sample config to be used.

Addressed comment and pushed a commit with the suggested changes.

@gab-arrobo gab-arrobo merged commit 82b7a1d into omec-project:master May 6, 2024
13 checks passed
@gab-arrobo gab-arrobo deleted the ptf-improvements branch May 6, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshmarikkannu sureshmarikkannu sureshmarikkannu approved these changes

@thakurajayL thakurajayL Awaiting requested review from thakurajayL

@amarsri28 amarsri28 Awaiting requested review from amarsri28

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gab-arrobo @sureshmarikkannu