Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve issues #152, #187, #188 and #192 - Handle both true/false values for swing control and update preset configuration flexibility #193

Merged

Conversation

omerfaruk-aran
Copy link
Owner

@omerfaruk-aran omerfaruk-aran commented Oct 19, 2024

This PR introduces three main updates:

  1. This PR ensures that both true and false values for horizontal and vertical swing control are properly handled.
  • Updated the __init__.py to pass both true and false values to the device.
  • Set default values for supports_horizontal_swing_ and supports_vertical_swing_ to false in samsung_ac_device.h.
  1. Preset Configuration Flexibility:

    • Now users can configure presets using both the short and long format.
    • The short format allows for quick usage such as quiet: true.
    • The long format provides more customization options, such as adding a name and enabling it with:
      quiet:
        name: "Makes no sound"
        enabled: true
      fast: true
    • This update ensures users can choose whichever method suits their needs, either for simplicity or more detailed configuration.
  2. Example YAML Update:

    • Updated the example.yaml to reflect the new flexibility in preset configuration.
    • Both short and long formats are now documented and shown, giving users a clear guide on how to use them in their configurations.

Issue Resolved:

Testing:

  • Tested on an actual device to ensure both configurations work seamlessly.
  • Logs were reviewed to ensure that changes were applied correctly without errors.
    image
  • Visual confirmation of preset functionalities with both short and long forms.

Let me know if further adjustments are needed, or if any additional tests should be conducted.

@omerfaruk-aran omerfaruk-aran changed the title Fix: Resolve issue #187 - Handle true/false values for swing control Fix: Resolve issue #187 and #192 - Handle true/false values for swing control Oct 19, 2024
@omerfaruk-aran omerfaruk-aran changed the title Fix: Resolve issue #187 and #192 - Handle true/false values for swing control Fix: Resolve issues #187 and #192 - Handle both true/false values for swing control and update preset configuration flexibility Oct 19, 2024
@omerfaruk-aran omerfaruk-aran changed the title Fix: Resolve issues #187 and #192 - Handle both true/false values for swing control and update preset configuration flexibility Fix: Resolve issues #152,#187,#188 and #192 - Handle both true/false values for swing control and update preset configuration flexibility Oct 21, 2024
@omerfaruk-aran omerfaruk-aran changed the title Fix: Resolve issues #152,#187,#188 and #192 - Handle both true/false values for swing control and update preset configuration flexibility Fix: Resolve issues #152, #187, #188 and #192 - Handle both true/false values for swing control and update preset configuration flexibility Oct 21, 2024
@lanwin
Copy link
Collaborator

lanwin commented Oct 21, 2024

Looks pretty good! Thank you very much!

@lanwin lanwin merged commit ea9e4f7 into omerfaruk-aran:main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants