Fix: Resolve issues #152, #187, #188 and #192 - Handle both true/false values for swing control and update preset configuration flexibility #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces three main updates:
true
andfalse
values for horizontal and vertical swing control are properly handled.__init__.py
to pass bothtrue
andfalse
values to the device.supports_horizontal_swing_
andsupports_vertical_swing_
tofalse
insamsung_ac_device.h
.Preset Configuration Flexibility:
quiet: true
.Example YAML Update:
example.yaml
to reflect the new flexibility in preset configuration.Issue Resolved:
Testing:
Let me know if further adjustments are needed, or if any additional tests should be conducted.