Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NonNasa] Prevent flooding the outdoor unit by registration requests #218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tristone-cz
Copy link

@tristone-cz tristone-cz commented Nov 5, 2024

πŸ“„ Description

What does this Pull Request do?

  • 🐞 Bug Fix
  • ✨ New Feature
  • πŸ”¨ Code Improvement
  • πŸ“š Documentation Update

✨ Key Changes

  1. .Adds control of registration requests towards outdoor unit at startup. Instead of flooding several times a second it sends now just one every two seconds.

πŸ”— Related Issues

Fixes: #191

βœ… Checklist

Please ensure the following before submitting your PR:

  • Code compiles without errors πŸ§‘β€πŸ’»
  • All tests pass successfully βœ…
  • Changes have been tested on relevant devices πŸ› οΈ
  • Documentation has been updated (if necessary) πŸ“–
  • This PR is ready for review πŸ”

🌐 Environment Information

πŸ”’ Versions

  • ESPHome Version: 2024.10.4
  • Home Assistant Version: 2024.10.2

🧩 Devices

  • Air Conditioner Type:
    • NON-NASA
    • NASA
    • Other
  • Air Conditioner Model: AR09RXWXCWKX
  • Outdoor Unit Model: AJ040NCJ2EG
  • ESP Device Model: M5STACK ATOM Lite + M5STACK RS-485
  • Wiring Configuration: F1/F2

@omerfaruk-aran
Copy link
Owner

Hey everyone,

@tristone-cz has made some updates in this PR to address the registration flooding issue. The new approach uses an interval-based mechanism to manage registration requests more efficiently. Before merging, we need to ensure these changes work correctly across different NonNASA devices.

@htht2001, @Goaheadz, @tech2urdoor – Could you please help test these updates on your devices? Here’s how you can proceed:

How to Test:

  1. Switch to @tristone-cz's Branch: Check out the branch from this PR and pull the latest changes.
  2. Set Up and Run: Load the updated code onto your device and observe how it performs, especially in scenarios like power outages or restarts.
  3. What to Look For:
    • Stability of communication with the outdoor unit.
    • Any delays or issues with initialization after power recovery.
    • Any unexpected behaviors or improvements.
external_components:
  - source: github://tristone-cz/esphome_samsung_hvac_bus@patch-slow-registration
    components: [samsung_ac]
    refresh: 0s

Feedback:

Please share your results, including:

  • Device model
  • Whether the issue is resolved or if any new issues arise
  • Any additional feedback or observations

Your assistance in testing is greatly appreciated, and your feedback will help ensure we release a reliable update. Thank you all for your support!

@omerfaruk-aran omerfaruk-aran added the help wanted Extra attention is needed label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nonNASA] No communication established if AC and ESP powered on together.
2 participants