Fix PHP docker configuration #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piping the fizzbuzz output to the host for measurement is bad for performance, especially as by default every line will also go to journald.
ZTS builds are only needed when running in a multithreaded SAPI and have a performance penalty.
The docker container runs in its own process group so score.py does not kill it. Work around this by trapping EXIT and killing the container directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous config piped all fizzbuzz output from the container to the host. This is inherently slow, but as docker logs all stdout by default it's glacial. Instead, run pv inside the container.
To make docker play well with score.py I had to trap the script exiting and manually docker kill the container - perhaps there's a better way?
Also changed the image to use a regular (non ZTS) php build, and enable the JIT compiler.