Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preventDefault call from the touch handlers #141

Merged
merged 1 commit into from
May 31, 2021

Conversation

omgovich
Copy link
Owner

@omgovich omgovich commented May 31, 2021

Fixes #136

See facebook/react#19651

Tested in MacOS Chrome, Android Chrome, MacOS Safari and iOS Safari — works as before.

@omgovich omgovich self-assigned this May 31, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #141 (1253a87) into master (e3c0830) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines          428       430    +2     
  Branches        62        63    +1     
=========================================
+ Hits           428       430    +2     
Impacted Files Coverage Δ
src/components/common/Interactive.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c0830...1253a87. Read the comment docs.

@github-actions
Copy link

Size Change: +12 B (0%)

Total Size: 4.23 kB

Filename Size Change
dist/index.module.js 4.23 kB +12 B (0%)

compressed-size-action

@omgovich omgovich merged commit 2adb95c into master May 31, 2021
@omgovich omgovich deleted the fix/prevent-passive-events branch May 31, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Error] Unable to preventDefault inside passive event listener invocation.
2 participants