Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dep to go modules #69

Merged
merged 23 commits into from
Oct 24, 2023
Merged

Migrate dep to go modules #69

merged 23 commits into from
Oct 24, 2023

Conversation

aashishgurung
Copy link
Contributor

Objective

Migrate from dep to Go modules

Description

  • Enabled Go modules
  • Removed vendors folder
  • Added dependencies to go.mod
  • Replaced deprecated io/ioutil to io
  • Updated code-coverage workflow

@aashishgurung aashishgurung requested review from danfowler, ajzkk, AnasNaouchi and a team October 20, 2023 02:12
@aashishgurung aashishgurung force-pushed the migrate_dep_to_go_modules branch from 567e0b2 to 6e00537 Compare October 20, 2023 05:58
@aashishgurung aashishgurung marked this pull request as ready for review October 20, 2023 06:01
@ajzkk
Copy link
Contributor

ajzkk commented Oct 24, 2023 •
edited
Loading

@aashishgurung

Shall we also fix FixtureBasePath in this PR? currently it is using build.Default.GOPATH.
If we fix FixtureBasePath, we can run test without the need of creating github.com/omise/omise-go in GOPATH folder.

@aashishgurung
Copy link
Contributor Author

@aashishgurung

Shall we also fix FixtureBasePath in this PR? currently it is using build.Default.GOPATH. If we fix FixtureBasePath, we can run test without the need of creating github.com/omise/omise-go in GOPATH folder.

Done. Thanks.

@aashishgurung aashishgurung merged commit ac294e1 into master Oct 24, 2023
@aashishgurung aashishgurung mentioned this pull request Oct 24, 2023
Merged
@danfowler danfowler deleted the migrate_dep_to_go_modules branch October 26, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfowler danfowler danfowler approved these changes

@ajzkk ajzkk ajzkk approved these changes

@AnasNaouchi AnasNaouchi Awaiting requested review from AnasNaouchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aashishgurung @ajzkk @danfowler