Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage report generation to test.sh and upload once #72

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Add code coverage report generation to test.sh and upload once #72

merged 7 commits into from
Oct 26, 2023

Conversation

danfowler
Copy link
Contributor

@danfowler danfowler commented Oct 26, 2023 •
edited
Loading

  • Fix test coverage reporting. For some reason, it must be a relative path now
  • Generate coverage report for test runs across Go versions
  • Upload coverage report only for one Go version (it only needs to be uploaded once)

Before:

ERROR: Coverage report can't be loaded, report file not found, ignoring this file src/github.com/omise/omise-go/

After:

INFO: Load coverage report from '/github/workspace/src/github.com/omise/omise-go/cover.out'

Screenshot 2023-10-26 at 1 00 20 PM

@danfowler danfowler marked this pull request as ready for review October 26, 2023 05:49
@danfowler danfowler requested review from aashishgurung and a team October 26, 2023 06:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@danfowler danfowler merged commit 9238950 into master Oct 26, 2023
@danfowler danfowler deleted the use-only-one-workflow-for-test-coverage branch October 26, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnasNaouchi AnasNaouchi AnasNaouchi approved these changes

@ajzkk ajzkk ajzkk approved these changes

@aashishgurung aashishgurung aashishgurung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danfowler @aashishgurung @ajzkk @AnasNaouchi