Add support for subschemas

[omissis]

This PR introduces support for anyOf and allOf subschemas.

[codecov]

Codecov Report

Attention: Patch coverage is 70.50147% with 100 lines in your changes are missing coverage. Please review.

Project coverage is 75.25%. Comparing base (d963216) to head (7bc36c4).
Report is 29 commits behind head on main.

❗ Current head 7bc36c4 differs from pull request most recent head 66cf143. Consider uploading reports for the commit 66cf143 to get more accurate results

Files	Patch %	Lines
pkg/generator/schema_generator.go	71.11%	17 Missing and 9 partials ⚠️
pkg/schemas/model.go	70.37%	12 Missing and 4 partials ⚠️
tests/data/validation/maxLength/maxLength.go	37.50%	13 Missing and 2 partials ⚠️
tests/data/validation/minLength/minLength.go	37.50%	13 Missing and 2 partials ⚠️
pkg/generator/output.go	54.16%	9 Missing and 2 partials ⚠️
internal/x/text/cases.go	0.00%	2 Missing and 1 partial ⚠️
pkg/generator/generate.go	62.50%	2 Missing and 1 partial ⚠️
pkg/generator/json_formatter.go	81.25%	2 Missing and 1 partial ⚠️
pkg/generator/yaml_formatter.go	76.92%	2 Missing and 1 partial ⚠️
tests/data/extraImports/gopkgYAMLv3/gopkgYAMLv3.go	0.00%	3 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   76.58%   75.25%   -1.33%     
==========================================
  Files          24       25       +1     
  Lines        1892     2138     +246     
==========================================
+ Hits         1449     1609     +160     
- Misses        354      425      +71     
- Partials       89      104      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[afrittoli]

Thanks for maintaining this great tool!
I have been trying to use it for a schema with anyOf and I have a comment on this PR.

When using anyOf, the type may not be set, and only be defined in the items which are part of the anyOf itself - see for instance https://json-schema.org/understanding-json-schema/reference/combining#anyOf.

Specifically, I tried running go-jsonschema from the lastest release as well as from this PR for this schema, and in both cases, I hit the EmptyInterfaceType.

type EmbeddedlinksarrayJson []interface{}

[omissis]

thanks! will look into it :)

[joepjoosten]

It breaks with this testcase:

{
    "$schema": "http://json-schema.org/draft-07/schema#",
    "$defs": {
        "foo": {
            "type": "object",
            "properties": {
                "foo": {
                    "type": "string"
                }
            },
            "required": [
                "foo"
            ]
        }
    },
    "id": "https://example.com/objectAllOf",
    "type": "object",
    "properties": {
        "flags": {
            "anyOf": [
                {
                    "type": "string"
                },
                {
                    "type": "boolean"
                }
            ]
        },
        "configurations": {
            "type": "array",
            "items": {
                "anyOf": [
                    {
                        "type": "object",
                        "properties": {
                            "bar": {
                                "type": "number"
                            }
                        },
                        "required": [
                            "bar"
                        ]
                    },
                    {
                        "type": "object",
                        "properties": {
                            "baz": {
                                "type": "boolean"
                            }
                        }
                    },
                    {
                        "$ref": "#/$defs/foo"
                    }
                ]
            }
        }
    }
}

[omissis]

@joepjoosten thanks for providing it! I will look at it as soon as I can.

[l0nedigit]

Any updates on the status of this PR? The fixes in this branch would be helpful to a project I am working on as well. Thanks

[LarsStegman]

Hi @omissis any updates on when you think this is ready for use? I am using allOf and anyOf quite extensively in one of my project and I would really like to use this tooling. Is there anything I might do to help get it ready?

[iiacoban42]

Seems to break when there is an allOf or anyOf at root level:

{
    "$schema": "http://json-schema.org/draft-07/schema#",
    "id": "https://example.com/objectAllOf",
    "type": "object",
    "allOf": [
      {
        "type": "object",
        "properties": {
          "foo": {
            "type": "string"
          }
        },
        "required": ["foo"]
      },
      {
        "type": "object",
        "properties": {
          "bar": {
            "type": "number"
          }
        },
        "required": ["bar"]
      },
      {
        "type": "object",
        "properties": {
          "configurations": {
            "type": "array",
            "items": {}
          }
        }
      }
    ]
  }

[omissis]

A quick update for all those who are waiting: I have just finished bringing this one up to date with all the things I have merged on main, and fixed all the broken tests code that I could find. This puts me in a position where I can look at all the feedback above and try to fix the issues. This is now the top priority for this repo to merge, and save for very small and trivial fixes and improvements, I will not merge anything else until this is done. Thank you for your patience.

[ptodev]

Thank you, @omissis! If you are looking for more inspiration for testing, it might be worth looking into what other json schema tools use in their repos:

• Marwes/schemafy
• openapi-json-schema-tools/openapi-json-schema-generator
• corvus-dotnet/Corvus.JsonSchema
• YousefED/typescript-json-schema
• GREsau/schemars
• victools/jsonschema-generator
• JamesNK/Newtonsoft.Json.Schema
• invopop/jsonschema

If I find time in the coming weeks, I could also take a look to see if there are any interesting test cases we could add.