Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #219 - Folder path separators are incorrectly replaced #224

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

Tesselay
Copy link
Contributor

@Tesselay Tesselay commented Apr 17, 2024

The regex for illegal characters of files includes : and / which are both needed to indicate a new folder on Mac and Win/Linux respectively. Created a separate regex and replacement function for folders where they are removed, so now folders are correctly created when setting the sync and attachment locations.

@sywhb
Copy link
Collaborator

sywhb commented Apr 18, 2024

Thanks @Tesselay , this is really needed

@sywhb sywhb changed the base branch from master to develop April 18, 2024 01:05
@sywhb sywhb merged commit d27e7bb into omnivore-app:develop Apr 18, 2024
0 of 6 checks passed
sywhb pushed a commit that referenced this pull request Apr 18, 2024
* Add separate illegal char regex for folders

* Fix correct folder path separators being replaced

Issue #219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants