New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept null in place of userAgent string #235

Merged

omrilotan merged 1 commit into main from accept_null_useragent

Jan 3, 2024

Owner

omrilotan commented Jan 3, 2024

I can see it is a common use case to use the headers getter, which makes sense.

With this change, users will be able to remove the check by the user and maintain type compliance. This allows cleaner code for the user.

- isbot(request.headers.get("user-agent") || "")
+ isbot(request.headers.get("user-agent"))


          Accept null in place of userAgent string

7b65a40

omrilotan merged commit d3e37df into main

1 check passed

omrilotan deleted the accept_null_useragent branch

January 3, 2024 16:52

omrilotan added a commit that referenced this pull request


          Accept null in place of userAgent string (#235)

0a22693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet