Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Exception messages #186

Closed
omry opened this issue Apr 4, 2020 · 0 comments · Fixed by #187
Closed

Standardize Exception messages #186

omry opened this issue Apr 4, 2020 · 0 comments · Fixed by #187
Labels
enhancement New feature or request
Milestone
OmegaConf 2.0.0

Comments

@omry
Copy link
Owner

omry commented Apr 4, 2020

There are some common information thas is applicable to most exceptions:

  1. what is the node this happened on.

  2. what is the key (if relevent)

  3. what is the value (if relevant)

  4. what is the full path of the key
    etc.

  5. refactor things such that all exceptions are going through the same formatting function.

  6. add tests for exception messages.
@omry omry added the enhancement New feature or request label Apr 4, 2020
@omry omry added this to the OmegaConf 2.0 milestone Apr 4, 2020
@omry omry mentioned this issue Apr 5, 2020
Merged
@omry omry closed this as completed in #187 Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
OmegaConf 2.0.0
Development

Successfully merging a pull request may close this issue.

Major internal rewrite omry/omegaconf
1 participant
@omry