Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major internal rewrite #187

Merged
merged 4 commits into from
Apr 5, 2020
Merged

Major internal rewrite #187

merged 4 commits into from
Apr 5, 2020

Conversation

omry
Copy link
Owner

@omry omry commented Apr 5, 2020

  1. Introduces reference type and handle assignment with reftype correctly.
  2. consistent exception messages (always contains full key name and type information).

closes #164
closes #186

@ghost
Copy link

ghost commented Apr 5, 2020 •
edited by ghost
Loading

Congratulations 🎉. DeepCode analyzed your code in 0.226 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@omry omry merged commit 2c6ea6a into master Apr 5, 2020
@omry omry deleted the 164 branch April 5, 2020 07:28
@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2020

This pull request introduces 3 alerts when merging fce9095 into 00b940b - view on LGTM.com

new alerts:

  • 3 for Redundant assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@omry