Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: apply mypy linting (E721) #1125

Closed
wants to merge 2 commits into from
Closed

tests: apply mypy linting (E721) #1125

wants to merge 2 commits into from

Conversation

MatteoVoges
Copy link
Contributor

Motivation

Apply flake8 rule E721 and fix tests.

Have you read the Contributing Guidelines on pull requests?

Yes

@MatteoVoges MatteoVoges marked this pull request as ready for review September 21, 2023 11:16
@odelalleau
Copy link
Collaborator

Thanks, but please don't worry about fixing CI until #1109 is merged, right now things are in a broken state.

@odelalleau
Copy link
Collaborator

I just merged #1109, can you please rebase #1124 and see if you still need this?

(NB: for your local dev setup you should re-create your env)

@MatteoVoges
Copy link
Contributor Author

Alright. It looks like this is not needed anymore 👍

@MatteoVoges MatteoVoges deleted the fix/apply-e721 branch September 22, 2023 15:24
@jlopezpena jlopezpena mentioned this pull request Oct 11, 2023
Merged
@jlopezpena
Copy link
Contributor

I think this might still be required, see CI errors in #1114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatteoVoges @odelalleau @jlopezpena