Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for dataclasses._MISSING_TYPE #1137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

majiayu000
Copy link

Motivation

I am using fairseq with Python 3.11, finding that there are some compatibility issues here.
If I want to use newer version, I have to change some code.

image

The error code as above

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I made a test file to reproduce this error.

Fixes

Fixes #1136

Related PRs

Not found

@omry
Copy link
Owner

omry commented Jul 15, 2024

It doesn't make sense to me to treat dataclass.MISSING_TYPE as an empty dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for dataclasses._MISSING_TYPE
2 participants