Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow conversion Path -> str #941

Merged
merged 2 commits into from
May 24, 2022
Merged

allow conversion Path -> str #941

merged 2 commits into from
May 24, 2022

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented May 23, 2022

Closes #934

@Jasha10
Copy link
Collaborator Author

Jasha10 commented May 23, 2022

TODO after merging: cherry-pick to 2.2_branch.

pixelb
pixelb approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@pixelb pixelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Jasha10 Jasha10 marked this pull request as ready for review May 24, 2022 01:02
@Jasha10 Jasha10 merged commit 6a4fd51 into omry:master May 24, 2022
@Jasha10 Jasha10 deleted the closes934 branch May 24, 2022 01:04
Jasha10 added a commit to Jasha10/omegaconf that referenced this pull request May 24, 2022
@Jasha10
allow conversion Path -> str (omry#941)
3f8677e
@Jasha10 Jasha10 mentioned this pull request May 24, 2022
Merged
Jasha10 added a commit that referenced this pull request May 24, 2022
@Jasha10
allow conversion Path -> str (#941) (#943)
28e553a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelb pixelb pixelb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implicit Path() to str conversion fails in 2.2.1
2 participants
@Jasha10 @pixelb