Feature/p#119563 link address (#944)

* remove unset(id), hide on detail

* add Function to get Addresslink

* fix test

* add return empty string when no id found

---------

Co-authored-by: Sascha Vogl <s.vogl@onoffice.com>

plugin/AddressList.php

@@ -274,7 +274,6 @@ private function fillAddressesById(array $records)
 			$elements = $address['elements'];
 
 			$additionalContactData = $this->collectAdditionalContactData($elements);
-			unset($elements['id']);
 			$this->_addressesById[$address['id']] = array_merge($elements, $additionalContactData);
 		}
 	}
@@ -580,8 +579,10 @@ public function generateImageAlt(int $addressId): string
 	public function getAddressLink(string $addressId): string
 	{
 		$pageId = $this->_pEnvironment->getDataAddressDetailViewHandler()
-				->getAddressDetailView()->getPageId();
-
+			->getAddressDetailView()->getPageId();
+		if($pageId == 0) {
+			return "";
+		}
 		$currentAddress = $this->getAddressById($addressId);
 		$firstName = $currentAddress['Vorname'] ?? '';
 		$lastName = $currentAddress['Name'] ?? '';

plugin/EstateDetail.php

@@ -330,5 +330,13 @@ public function getShowEstateMarketingStatus(): bool
 	{
 		return $this->getDataView()->getShowStatus();
 	}
-
+	/**
+	 * Returns addresslink for given addressid
+	 * @param string $id
+	 * @return string  
+	 */
+	public function getAddressLink(string $id) : string 
+	{
+		return $this->getEnvironment()->getAddressList()->getAddressLink($id);
+	}
 }

templates.dist/address/default_detail.php

@@ -52,7 +52,7 @@
     <div class="oo-address-fieldlist">
         <?php
             foreach ($escapedValues as $field => $value) {
-                if (in_array($field, $addressName) || empty($value)) {
+                if (in_array($field, $addressName) || empty($value) || $field == 'id') {
                     continue;
                 }
                 echo '<div class="oo-address-field">';

tests/TestClassAddressList.php

@@ -76,11 +76,13 @@ class TestClassAddressList
 				'01234567890',
 				'01122334455',
 			],
+			'id' => 13
 		),
 		37 => array(
 			'Name' => 'Fleißig',
 			'KdNr' => 12,
 			'Vorname' => 'Heinrich',
+			'id' => 37
 		),
 	];