Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release = old bug again #496

Closed
fredericalpers opened this issue Apr 11, 2023 Discussed in #495 · 10 comments
Closed

New release = old bug again #496

fredericalpers opened this issue Apr 11, 2023 Discussed in #495 · 10 comments
Labels
bug Indicates an unexpected problem or unintended behaviour

Comments

@fredericalpers
Copy link
Member

Discussed in #495

Originally posted by fredericalpers April 11, 2023
After releasing the new Plugin Version we encountered an old bug again.

In enterprise deactivated fields will lead to critical error.

@fredericalpers fredericalpers added the bug Indicates an unexpected problem or unintended behaviour label Apr 11, 2023
@fredericalpers
Copy link
Member Author

fredericalpers commented Apr 11, 2023

@dai-eastgate Please try to squeeze this in so we can release a Hotfix. If I remember we had this fixed before by "skipping" the deactivated fields.

@dai-eastgate
Copy link
Contributor

@dai-eastgate Please try to squeeze this in so we can release a Hotfix. If I remember we had this fixed before by "skipping" the deactivated fields.

I will check and fix it

@dai-eastgate
Copy link
Contributor

@fredericalpers Can you be more specific about where the error occurs?

@fredericalpers
Copy link
Member Author

fredericalpers commented Apr 11, 2023

@fredericalpers Can you be more specific about where the error occurs?

@dai-eastgate In v4.10 of the plugin, in enterprise all deactivated fields will cause an critial error in WordPress when used in a property list. See the attachment below:

deactived

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Apr 12, 2023

@fredericalpers
we miss "skipping" the deactivated fields When this fields add to "FilterableFields"
image

I fixed at #497
Pls check again.
This demo video.
ex: ind_2082_Feld_ObjTech40

33244.mp4

@fredericalpers
Copy link
Member Author

Perfect, thank you :)

@andernath
Copy link
Contributor

Thanks @dai-eastgate for your fast fix. :)
Estatelist works ✔
But we still have problem while saving in backend if some fields are inactive in enterprise. It doesn't matter if the fields are filterable or not.

2023-04-12 10_20_53-‹ WP-Plugin Test — WordPress

2023-04-12 10_21_08-WordPress › Fehler

@dai-eastgate
Copy link
Contributor

yes, I will check it now

@yennt89
Copy link
Contributor

yennt89 commented Apr 13, 2023

@andernath @fredericalpers I fixed it.
This is demo video, pls check again

IMG_8058.MP4

@fredericalpers
Copy link
Member Author

Thank you! We will check again and give our feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behaviour
Projects
None yet
Development

No branches or pull requests

4 participants