P#61223 19600 reload edit pages after saving and show copyable shortcode there #160

vu-vuong-esg · 2021-12-31T02:06:43Z

No description provided.

coveralls · 2021-12-31T02:09:25Z

Pull Request Test Coverage Report for Build 2581497061

44 of 93 (47.31%) changed or added relevant lines in 11 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 80.382%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
plugin/Controller/AdminViewController.php	4	5	80.0%
plugin/Renderer/InputFieldEmailRenderer.php	4	5	80.0%
plugin/Renderer/InputFieldComplexSortableDetailListContentDefault.php	0	2	0.0%
plugin/Renderer/InputFieldComplexSortableDetailListRenderer.php	0	2	0.0%
plugin/Renderer/InputModelRenderer.php	0	5	0.0%
plugin/Model/FormModelBuilder/FormModelBuilderDBAddress.php	0	19	0.0%
plugin/Model/FormModelBuilder/FormModelBuilderDBEstateUnitListSettings.php	0	19	0.0%

Files with Coverage Reduction	New Missed Lines	%
plugin/Model/InputModelBase.php	1	86.11%
plugin/Renderer/InputFieldComplexSortableDetailListContentDefault.php	1	0%

Totals
Change from base Build 2568534500:	-0.2%
Covered Lines:	6179
Relevant Lines:	7687

💛 - Coveralls

hungnc89 · 2022-01-12T10:35:19Z

@jayay could you please review this PR?

hungnc89 · 2022-02-07T03:22:38Z

@jayay please check PR help me, thanks

hungnc89 · 2022-02-23T02:44:51Z

@jayay could you please review this PR?

jayay · 2022-03-13T12:10:28Z

js/onoffice-copycode.js

+jQuery(document).ready(function($){
+    $('#button-copy').click(function() {
+        var copyCode = document.getElementsByTagName("code").item(0);
+        // console.log(copyCode);


please remove the debug code

jayay · 2022-03-13T12:11:43Z

plugin/Model/FormModelBuilder/FormModelBuilderDBEstateListSettings.php


+		$code = '[oo_estate view=="'.$listName.'"]';


one = too much

jayay · 2022-03-13T12:13:33Z

plugin/Renderer/InputFieldButtonRenderer.php

+	{
+		$id = HtmlIdGenerator::generateByString($this->_id);
+		echo '<input type="button" class="button" id="button-copy" name="'
+			.esc_attr($id).'" value="'.esc_html__('Copy !', 'onoffice-for-wp-websites').'" '


Copy! would be better

vu-vuong-esg · 2022-03-17T12:26:22Z

@jayay i fixed, can you check PR help me ?

jayay · 2022-03-31T08:15:36Z

plugin/Model/FormModelBuilder/FormModelBuilderDBEstateListSettings.php


+		$codes = '[oo_estate view=="'.$listName.'"]';


one = too much here

jayay · 2022-03-31T08:16:59Z

tests/TestClassFormModelBuilderDBEstateListSettings.php

+
+	public function testCreateInputModelButton()
+	{
+		$pInstance = $this->getMockBuilder(FormModelBuilderDBEstateListSettings::class)


Testing a class using a mock of itself doesn't really make sense

i fixed it, please check PR help me !

github-actions · 2022-06-22T09:34:37Z

Steps to install the approved version:

Download onoffice-4.0-62-g8cd0efb5-please-unpack.zip from https://github.com/onOfficeGmbH/oo-wp-plugin/actions/runs/2541298938.
Unpack the downloaded file to get another .zip file.
Upload that inner .zip file to WordPress.

dai-eastgate · 2022-06-22T10:45:45Z

This is the test video:

Reload_edit_pages_after_saving_and_show_copyable_shortcode_there_2.mp4

…how-copyable-shortcode-there

jmaas-onoffice

There's too many changes for me to review them, but I will test it.

github-actions · 2022-06-27T15:17:09Z

Steps to install the approved version:

Download onoffice-4.1-60-g72efd7b1-please-unpack.zip from https://github.com/onOfficeGmbH/oo-wp-plugin/actions/runs/2570166521.
Unpack the downloaded file to get another .zip file.
Upload that inner .zip file to WordPress.

jmaas-onoffice

I didn't explicitely ask before, but it would be great to also have a unified way of showing shortcodes.

The detail view does not use the new shortcode display:

It should look like this:
Similarly, when the detail view shortcode is not used

it should look like this:
Unit list settings do not show a shortcode.

They should have the same shortcode as the estate list settings (also the same behavior when creating a new unit list).

dai-eastgate · 2022-06-28T11:40:42Z

Do we apply the new display shortcode for other pages (estate list, address list, form, unit lits)?

jmaas-onoffice · 2022-06-28T14:38:46Z

I'm not sure I understand. What do you mean? 😅

github-actions · 2022-06-29T09:07:42Z

Steps to install the approved version:

Download onoffice-4.1-63-gcbd4c0ae-please-unpack.zip from https://github.com/onOfficeGmbH/oo-wp-plugin/actions/runs/2581970021.
Unpack the downloaded file to get another .zip file.
Upload that inner .zip file to WordPress.

jmaas-onoffice

It all works great, thanks! Another PR finally finished. 🎉

TangHien4698 added 2 commits December 30, 2021 07:22

show short code

e778ddd

add reload when save

6d0cc32

vu-vuong-esg requested a review from jayay December 31, 2021 02:06

TangHien4698 added 2 commits January 4, 2022 17:39

add unit test and change button copy

192e289

add more test

8e46f7c

michaelarnold-dev changed the title ~~19600 reload edit pages after saving and show copyable shortcode there~~ P#61223 19600 reload edit pages after saving and show copyable shortcode there Jan 13, 2022

vu-vuong-esg removed the request for review from jayay January 25, 2022 04:07

TangHien4698 added 3 commits January 26, 2022 00:48

add copy short code

a60bd75

remove comment

4d89130

fix conflict file admin.css

9b7cd74

hungnc89 requested a review from jayay February 7, 2022 03:21

jayay suggested changes Mar 13, 2022

View reviewed changes

tang-hien-egs force-pushed the 19600-Reload-edit-pages-after-saving-and-show-copyable-shortcode-there branch from 819190d to 9b7cd74 Compare March 15, 2022 03:55

tang-hien-egs added 3 commits March 15, 2022 11:59

change code and fix conflict

6ee2d15

remove css not use

e1b0fb5

fix test in class FormModelBuilderDBForm

da59f69

tang-hien-egs requested a review from jayay March 17, 2022 03:22

LongTrong-exe mentioned this pull request Mar 28, 2022

P#52107 Allow sorting by all fields : gaps in the implementation #152

Closed

tang-hien-egs force-pushed the 19600-Reload-edit-pages-after-saving-and-show-copyable-shortcode-there branch from 6312cd3 to da59f69 Compare March 29, 2022 09:10

tang-hien-egs added 3 commits March 29, 2022 16:14

updated css

93aec2b

fix conflict file mo

54fc528

format code

b83d6be

jmaas-onoffice added the feedback-jakob label Mar 30, 2022

jayay suggested changes Mar 31, 2022

View reviewed changes

add mock method in unit test

364ed53

update post form for all pages

070dfb8

dai-eastgate dismissed yeneastgate’s stale review via 070dfb8 June 20, 2022 12:13

dai-eastgate and others added 8 commits June 20, 2022 19:21

add admin-post action

f09cf82

add shortcode for address page

a64d247

resolve conflict

0565dac

update unit test

fe0bc12

update unit test

d87ecb8

register script for address list page

d0697a3

resolve conflict

22d6f24

refactor code

8cd0efb

LongTrong-exe previously approved these changes Jun 22, 2022

View reviewed changes

LongTrong-exe requested a review from jmaas-onoffice June 22, 2022 10:32

Merge branch 'master' into 19600-Reload-edit-pages-after-saving-and-s…

72efd7b

…how-copyable-shortcode-there

jmaas-onoffice approved these changes Jun 27, 2022

View reviewed changes

jmaas-onoffice suggested changes Jun 28, 2022

View reviewed changes

update shortcode display for detail page & add shortcode for unit list

2cfab7a

dai-eastgate dismissed LongTrong-exe’s stale review via 2cfab7a June 29, 2022 06:40

dai-eastgate and others added 2 commits June 29, 2022 13:48

update unit test

ada8a0b

reformat code

cbd4c0a

dai-eastgate requested a review from jmaas-onoffice June 29, 2022 07:57

LongTrong-exe approved these changes Jun 29, 2022

View reviewed changes

jmaas-onoffice approved these changes Jun 29, 2022

View reviewed changes

jmaas-onoffice merged commit bdb6c93 into master Jun 29, 2022

jmaas-onoffice deleted the 19600-Reload-edit-pages-after-saving-and-show-copyable-shortcode-there branch June 29, 2022 14:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

P#61223 19600 reload edit pages after saving and show copyable shortcode there #160

P#61223 19600 reload edit pages after saving and show copyable shortcode there #160

vu-vuong-esg commented Dec 31, 2021

coveralls commented Dec 31, 2021 •

edited

Loading

hungnc89 commented Jan 12, 2022

hungnc89 commented Feb 7, 2022

hungnc89 commented Feb 23, 2022

jayay Mar 13, 2022

jayay Mar 13, 2022

jayay Mar 13, 2022

vu-vuong-esg commented Mar 17, 2022

jayay Mar 31, 2022

jayay Mar 31, 2022

tang-hien-egs Apr 5, 2022

github-actions bot commented Jun 22, 2022

dai-eastgate commented Jun 22, 2022

jmaas-onoffice left a comment

github-actions bot commented Jun 27, 2022

jmaas-onoffice left a comment •

edited

Loading

dai-eastgate commented Jun 28, 2022

jmaas-onoffice commented Jun 28, 2022

github-actions bot commented Jun 29, 2022

jmaas-onoffice left a comment

P#61223 19600 reload edit pages after saving and show copyable shortcode there #160

P#61223 19600 reload edit pages after saving and show copyable shortcode there #160

Conversation

vu-vuong-esg commented Dec 31, 2021

coveralls commented Dec 31, 2021 • edited Loading

Pull Request Test Coverage Report for Build 2581497061

💛 - Coveralls

hungnc89 commented Jan 12, 2022

hungnc89 commented Feb 7, 2022

hungnc89 commented Feb 23, 2022

jayay Mar 13, 2022

Choose a reason for hiding this comment

jayay Mar 13, 2022

Choose a reason for hiding this comment

jayay Mar 13, 2022

Choose a reason for hiding this comment

vu-vuong-esg commented Mar 17, 2022

jayay Mar 31, 2022

Choose a reason for hiding this comment

jayay Mar 31, 2022

Choose a reason for hiding this comment

tang-hien-egs Apr 5, 2022

Choose a reason for hiding this comment

github-actions bot commented Jun 22, 2022

dai-eastgate commented Jun 22, 2022

jmaas-onoffice left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 27, 2022

jmaas-onoffice left a comment • edited Loading

Choose a reason for hiding this comment

dai-eastgate commented Jun 28, 2022

jmaas-onoffice commented Jun 28, 2022

github-actions bot commented Jun 29, 2022

jmaas-onoffice left a comment

Choose a reason for hiding this comment

coveralls commented Dec 31, 2021 •

edited

Loading

jmaas-onoffice left a comment •

edited

Loading