Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

49333 Fix critical bug: forms with recaptcha can not be sended and onoffice-captchacontrol.js is also loaded in forms without recaptcha #837

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

yeneastgate
Copy link
Contributor

@yeneastgate yeneastgate commented Jun 12, 2024

related to #836
changed log:
Fix critical bug reCaptcha

@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9480541231

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 79.595%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/ScriptLoader/ScriptLoaderGenericConfigurationDefault.php 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
plugin/ScriptLoader/ScriptLoaderGenericConfigurationDefault.php 1 32.16%
Totals Coverage Status
Change from base Build 9461527919: -0.007%
Covered Lines: 8324
Relevant Lines: 10458

💛 - Coveralls

@andernath andernath added this to the v4.20 milestone Jun 13, 2024
@fredericalpers fredericalpers added bug Indicates an unexpected problem or unintended behaviour deploy test Triggers event to create test version labels Jun 17, 2024
Copy link

Steps to install the approved version:

  1. Download onoffice-4.19-20-g0ff859a4-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9543364119.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath merged commit ac67127 into master Jun 17, 2024
10 checks passed
@andernath andernath deleted the 49333-fix-critical-bug-forms-with-recaptcha branch June 17, 2024 07:31
Copy link

Steps to install the approved version:

  1. Download onoffice-4.19-20-g0ff859a4-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9543691214.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behaviour deploy test Triggers event to create test version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants