Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

51413 Critical error when using empty "Radius" for Similar Estates #869

Merged
merged 14 commits into from
Nov 7, 2024
Merged

51413 Critical error when using empty "Radius" for Similar Estates #869

merged 14 commits into from
Nov 7, 2024

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Jul 26, 2024 •
edited
Loading

related to #859
changed log:
Changed HTML input type from text to number for radius and record per page

@coveralls
Copy link

coveralls commented Jul 26, 2024 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 10607653307

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.285%
Totals Coverage Status
Change from base Build 10593215248: 0.0%
Covered Lines: 8479
Relevant Lines: 10831
💛 - Coveralls

@fredericalpers fredericalpers added this to the v5.5 milestone Jul 26, 2024
@fredericalpers fredericalpers added breaking change Change that causes critical errors in the plugin or its components QA Issue or Pull request that is in review component: property detail page Issue, Pull Request or Discussion related to property detail page labels Jul 26, 2024
@fredericalpers fredericalpers linked an issue Jul 26, 2024 that may be closed by this pull request
Critical error when using empty "Radius" for Similar Estates #859
Closed
4 tasks
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Steps to install the approved version:

  1. Download onoffice-5.1.3-10-gfc7f89c0-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11216986808.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers
Copy link
Member

@dai-eastgate Thank you for the update, it's working well now that no error is shown for an empty radius value! 🎉

I do have a small improvement suggestion regarding the radius field: it should not be possible to enter a negative value. Currently, it's still possible to input negative numbers, which probably doesn’t make sense in this context. Could you add a validation to prevent negative values?

Thanks in advance!

@dai-eastgate
Copy link
Contributor Author

@fredericalpers I fixed it. Please help us to review it. Thanks!

radius_similar.mp4

@fredericalpers
Copy link
Member

@dai-eastgate thank you, I will reviews this as soon as possible

@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Steps to install the approved version:

  1. Download onoffice-5.1.4-24-g8e85bbdb-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11718475275.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

miauzjpg
miauzjpg approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@miauzjpg miauzjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Steps to install the approved version:

  1. Download onoffice-5.1.4-24-g8e85bbdb-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11722237072.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@miauzjpg miauzjpg merged commit 75071e3 into master Nov 7, 2024
8 checks passed
@miauzjpg miauzjpg deleted the 51413-critical-error-when-using-empty-radius-for-similar-estates branch November 7, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miauzjpg miauzjpg miauzjpg approved these changes

Assignees
No one assigned
Labels
breaking change Change that causes critical errors in the plugin or its components component: property detail page Issue, Pull Request or Discussion related to property detail page deploy test Triggers event to create test version QA Issue or Pull request that is in review
Projects
None yet
Milestone
v5.5
Development

Successfully merging this pull request may close these issues.

Critical error when using empty "Radius" for Similar Estates
4 participants
@dai-eastgate @coveralls @fredericalpers @miauzjpg