add overallcount for addresses #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericalpers
added
feature
andernath
reviewed
Oct 4, 2024
plugin/AddressList.php
Outdated
| @@ -159,28 +165,28 @@ public function __construct(DataViewAddress $pDataViewAddress = null, AddressLis | |||
| public function loadAddressesById(array $addressIds, array $fields) | |||
| { | |||
| $this->_pEnvironment->getFieldnames()->loadLanguage(); | |||
| $pApiCall = new APIClientActionGeneric | |||
| $this->_pApiClientAction = new APIClientActionGeneric | |||
| ($this->_pEnvironment->getSDKWrapper(), onOfficeSDK::ACTION_ID_READ, 'address'); | |||
There was a problem hiding this comment.
Ist das nicht redundant, wenn das schon im Konstruktor passiert?
There was a problem hiding this comment.
ja, definitiv... kann raus
plugin/AddressList.php
Outdated
| @@ -205,21 +211,21 @@ public function loadAddresses(int $inputPage = 1) | |||
| $apiOnlyFields = $pModifier->getAllAPIFields(); | |||
| $parameters = $pDataListViewToApi->buildParameters($apiOnlyFields, $this->_pDataViewAddress, $newPage, true); | |||
|
|
|||
| $pApiCall = new APIClientActionGeneric | |||
| $this->_pApiClientAction = new APIClientActionGeneric | |||
| ($this->_pEnvironment->getSDKWrapper(), onOfficeSDK::ACTION_ID_READ, 'address'); | |||
There was a problem hiding this comment.
Ist das nicht redundant, wenn das schon im Konstruktor passiert?
There was a problem hiding this comment.
ja, definitiv... kann raus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.