54399 Correct handling of Umlauts and Special Characters during language switch #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
fredericalpers
added
bug
|
Steps to install the approved version:
|
…ial-characters-during-language-switch
andernath
added
deploy test
|
Steps to install the approved version:
|
andernath
reviewed
Nov 15, 2024
There was a problem hiding this comment.
@dai-eastgate
Everything looks fine :), just one question. Could you please take a look?
| @@ -35,6 +35,7 @@ class EstateDetailUrl | |||
| * @param string|null $title | |||
| * @param string|null $oldUrl | |||
| * @param bool $flag | |||
| * @param string|null $switchLocale | |||
There was a problem hiding this comment.
@andernath It really isn't necessary. I'll fix it.
…ial-characters-during-language-switch
andernath
deleted the
54399-correct-handling-of-umlauts-and-special-characters-during-language-switch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #953
changed log: