Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Hierarchy endpoint lineage ids enhancement and refactor ✨ #118

Merged
merged 8 commits into from
Feb 5, 2025

Conversation

ndegwamartin
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Resolves #112
Resolves #113

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

@ndegwamartin ndegwamartin changed the title Linear optimization Location Hierarchy endpoint lineage ids enhancement and refactor ✨ Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 52.71318% with 61 lines in your changes missing coverage. Please review.

Project coverage is 63.52%. Comparing base (5eac4bd) to head (28c1b36).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../fhir/gateway/plugins/PermissionAccessChecker.java 0.00% 32 Missing ⚠️
...teway/plugins/LocationHierarchyEndpointHelper.java 69.47% 19 Missing and 10 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #118      +/-   ##
============================================
+ Coverage     63.13%   63.52%   +0.38%     
- Complexity      224      235      +11     
============================================
  Files            16       16              
  Lines          1492     1601     +109     
  Branches        173      199      +26     
============================================
+ Hits            942     1017      +75     
- Misses          461      483      +22     
- Partials         89      101      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

exec/pom.xml Outdated Show resolved Hide resolved
@ndegwamartin ndegwamartin merged commit 6fe8901 into main Feb 5, 2025
2 of 3 checks passed
@ndegwamartin ndegwamartin deleted the linear-optimization branch February 5, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants