Add support for location lineage post processing #119
Conversation
lincmba
force-pushed
the
110-create-location-ancestor-tags
branch
from
cbb10e7 to
227b66e
Compare
Better target to requests to location endpoint
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
============================================
+ Coverage 62.96% 63.13% +0.17%
- Complexity 221 224 +3
============================================
Files 16 16
Lines 1477 1492 +15
Branches 168 173 +5
============================================
+ Hits 930 942 +12
- Misses 460 461 +1
- Partials 87 89 +2 ☔ View full report in Codecov by Sentry. |
plugins/src/main/java/org/smartregister/fhir/gateway/plugins/SyncAccessDecision.java
Outdated
Show resolved
Hide resolved
plugins/src/test/java/org/smartregister/fhir/gateway/plugins/SyncAccessDecisionTest.java
Outdated
Show resolved
Hide resolved
| String locationId; | ||
| if (StringUtils.isNotBlank(resultContent)) { | ||
| IBaseResource parsedResource = this.fhirR4JsonParser.parseResource(resultContent); | ||
| if (parsedResource instanceof Location) { | ||
| return ((Location) parsedResource).getIdElement().getIdPart(); | ||
| } | ||
| } | ||
|
|
||
| String[] pathParts = requestPath.split("/"); | ||
| locationId = pathParts[pathParts.length - 1]; |
There was a problem hiding this comment.
If these two conditions are primarily for differentiating between a PUT and POST I'd recommend passing the request Method (PUT|POST) as a parameter and using an if else statement for more clarity
There was a problem hiding this comment.
They're not for differentiating the request method. They are there incase a request is made but the resource updated/created is not returned in the json or isn't a valid location resource. Done away with one condition though
Update test to handle this merge
IMPORTANT: Where possible all PRs must be linked to a Github issue
Resolves [link to issue]
Engineer Checklist
bug fixes
option(s) on the
README.mdmvn spotless:checkto check my code follows the project'sstyle guide
mvn clean test jacoco:reportto confirm the coverage reportwas generated at
plugins/target/site/jacoco/index.htmlmvn clean packageright before creating this pull request.