Add Dockerfile and docker workflow #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile
Outdated
| ENV TOKEN_ISSUER="http://localhost/auth/realms/test" | ||
| ENV PROXY_TO="http://localhost:8080/fhir" | ||
| ENV BACKEND_TYPE="HAPI" | ||
| ENV ACCESS_CHECKER="list" |
There was a problem hiding this comment.
do we want to point to our default here i.e. "permission" or it is ok since we will override during deploy?
There was a problem hiding this comment.
I don't mind removing it.
add docker workflow
bennsimon
force-pushed
the
add-dockerworkflow
branch
from
0501bdc to
c42c9ed
Compare
|
Follow-up on background conversations, I'm fine, and I think it's even potentially better, for this docker file with compiled code but not source code, to be public. We'd prefer it to be in the onaio org than opensrp |
ndegwamartin
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Resolves [link to issue]
Engineer Checklist
bug fixes
mvn spotless:checkto check my code follows the project'sstyle guide
mvn clean packageright before creating this pull request.