Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm envs checker script #1512

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Add helm envs checker script #1512

merged 4 commits into from
Dec 18, 2024

Conversation

peterMuriuki
Copy link
Collaborator

Changes included with this PR

Adds a command line script that checks env variables discrepancies between this apps code and express's code to those listed in the helm values file

Copy link
Collaborator

@kahummer kahummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add tests for the various utility functions. Overall, it looks good to me (LGTM)

@peterMuriuki
Copy link
Collaborator Author

It would be great to add tests for the various utility functions. Overall, it looks good to me (LGTM)

thanks Kahummer, this is noted. The goal for this was to be very lightweight single use dev utilities, Made me de-prioritize tests at the moment.

@peterMuriuki peterMuriuki merged commit 6f8308d into main Dec 18, 2024
0 of 2 checks passed
@peterMuriuki peterMuriuki deleted the 1501-add-script branch December 18, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants