Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use login URL to clear site data #78

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Use login URL to clear site data #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion oidc/viewsets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,10 @@ def _get_client(self, auth_server: str) -> Optional[OpenIDClient]:
def login(self, request: HttpRequest, **kwargs: dict) -> HttpResponse:
client = self._get_client(auth_server=kwargs.get("auth_server"))
if client:
return client.login(redirect_after=request.query_params.get("next"))
response = client.login(redirect_after=request.query_params.get("next"))
# Add Clear-Site-Data headers
response["Clear-Site-Data"] = '"cache", "cookies"'
return response
return HttpResponseBadRequest(
_("Unable to process OpenID connect login request."),
)
Expand Down
11 changes: 10 additions & 1 deletion tests/test_viewsets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from mock import MagicMock, patch
from rest_framework.test import APIRequestFactory

from oidc.viewsets import UserModelOpenIDConnectViewset
from oidc.viewsets import UserModelOpenIDConnectViewset, BaseOpenIDConnectViewset

User = get_user_model()

Expand Down Expand Up @@ -592,6 +592,15 @@ def test_auth_code_flow(self, mock_retrieve_auth_code):
self.assertEqual(response.status_code, 302)
self.assertEqual(response.url, "http://localhost:3000")

@override_settings(OPENID_CONNECT_AUTH_SERVERS=OPENID_CONNECT_AUTH_SERVERS)
@override_settings(OPENID_CONNECT_VIEWSET_CONFIG=OPENID_CONNECT_VIEWSET_CONFIG)
def test_base_open_id_connect_viewset(self):
viewset_class = BaseOpenIDConnectViewset
view = viewset_class.as_view({"get": "login"})
request = self.factory.get("/")
response = view(request, auth_server="default")
self.assertEqual(response.headers["Clear-Site-Data"], '"cache", "cookies"')

@patch(
"oidc.viewsets.OpenIDClient.verify_and_decode_id_token",
MagicMock(
Expand Down