Skip to content

Commit

Permalink
Temporary dsiable Operation Too Large Exception
Browse files Browse the repository at this point in the history
- settign limit to 50000 to efftively disable it
- ericsson is not ready and wil infrom us when it can be enabled again

Issue-ID: CPS-2164
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ib1a8308a20bd77fcba9c4c9fc94739d5dd731b1f
  • Loading branch information
toine-at-est committed Apr 19, 2024
1 parent b4e377e commit 9932131
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public class NcmpPassthroughResourceRequestHandler extends NcmpDatastoreRequestH

private static final Object noReturn = null;

private static final int MAXIMUM_CM_HANDLES_PER_OPERATION = 50;
private static final int MAXIMUM_CM_HANDLES_PER_OPERATION = 50000;

private static final String PAYLOAD_TOO_LARGE_TEMPLATE = "Operation '%s' affects too many (%d) cm handles";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,15 @@ class NcmpDatastoreRequestHandlerSpec extends Specification {

def 'Attempt to execute async data operation request with too many cm handles.'() {
given: 'a data operation definition with too many cm handles'
def cmHandleIds = new String[51]
def tooMany = objectUnderTest.MAXIMUM_CM_HANDLES_PER_OPERATION+1
def cmHandleIds = new String[tooMany]
def dataOperationDefinition = new DataOperationDefinition(operationId: 'abc', operation: 'read', datastore: 'ncmp-datastore:passthrough-running', cmHandleIds: cmHandleIds)
when: 'data operation request is executed'
objectUnderTest.executeRequest('someTopic', new DataOperationRequest(dataOperationDefinitions:[dataOperationDefinition]), NO_AUTH_HEADER)
then: 'a payload too large exception is thrown'
def exceptionThrown = thrown(PayloadTooLargeException)
and: 'the error message contains the offending number of cm handles'
assert exceptionThrown.message == "Operation 'abc' affects too many (51) cm handles"
assert exceptionThrown.message == "Operation 'abc' affects too many (${tooMany}) cm handles"
}

}

0 comments on commit 9932131

Please sign in to comment.