feat: implement the adena wallet provider #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinoosss
force-pushed
the
ADN-604-implement-the-adena-wallet-provider
branch
from
b6456dd
to
cd792ad
Compare
|
@RezaRahemtola Can you give it a review? |
Comment on lines
+25
to
+41
| export enum WalletResponseFailedType { | ||
| NOT_CONNECTED = 'NOT_CONNECTED', | ||
| UNRESOLVED_TRANSACTION_EXISTS = 'UNRESOLVED_TRANSACTION_EXISTS', | ||
| INVALID_FORMAT = 'INVALID_FORMAT', | ||
| WALLET_LOCKED = 'WALLET_LOCKED', | ||
| ACCOUNT_MISMATCH = 'ACCOUNT_MISMATCH', | ||
| NO_ACCOUNT = 'NO_ACCOUNT', | ||
| TRANSACTION_FAILED = 'TRANSACTION_FAILED', | ||
| SIGN_FAILED = 'SIGN_FAILED', | ||
| ALREADY_CONNECTED = 'ALREADY_CONNECTED', | ||
| NETWORK_TIMEOUT = 'NETWORK_TIMEOUT', | ||
| REDUNDANT_CHANGE_REQUEST = 'REDUNDANT_CHANGE_REQUEST', | ||
| NETWORK_ALREADY_EXISTS = 'NETWORK_ALREADY_EXISTS', | ||
| UNADDED_NETWORK = 'UNADDED_NETWORK', | ||
| UNSUPPORTED_TYPE = 'UNSUPPORTED_TYPE', | ||
| UNEXPECTED_ERROR = 'UNEXPECTED_ERROR', | ||
| } |
There was a problem hiding this comment.
should we unify those types in the future in a common package used by the main Adena repo and this SDK ?
There was a problem hiding this comment.
Yes, I would like to unify the types and responses.
If the SDK and wallet responses were separate, it wouldn't be a problem if the provider did the mapping for me, but I'd have to manage them separately and always consider what I'm missing.
dongwon8247
approved these changes
Sep 4, 2024
|
@RezaRahemtola We have a PR that implements the features of the SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does:
Define the wallet provider that will be managed in your SDK instance, and implement the adena wallet provider.
Change the adena methods to provider.