fix: Fix injection and pop window collision (#474)

onbloc · Apr 9, 2024 · 919cb17 · 919cb17
1 parent fe9f54e
commit 919cb17
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/packages/adena-extension/src/inject/message/message-handler.ts b/packages/adena-extension/src/inject/message/message-handler.ts
@@ -1,6 +1,6 @@
 import { HandlerMethod } from '.';
 import { InjectionMessage, InjectionMessageInstance } from './message';
-import { existsPopups } from './methods';
+import { existsPopups, removePopups } from './methods';
 import { InjectCore } from './methods/core';
 
 export class MessageHandler {
@@ -52,10 +52,7 @@ export class MessageHandler {
     }
     const isPopup = await existsPopups();
     if (isPopup) {
-      sendResponse(
-        InjectionMessageInstance.failure('UNRESOLVED_TRANSACTION_EXISTS', {}, message.key),
-      );
-      return true;
+      await removePopups();
     }
     switch (message.type) {
       case 'DO_CONTRACT':

diff --git a/packages/adena-extension/src/inject/message/methods/common.ts b/packages/adena-extension/src/inject/message/methods/common.ts
@@ -60,6 +60,15 @@ export const existsPopups = async (): Promise<boolean> => {
   return windows.findIndex((window) => window.type === 'popup') > -1;
 };
 
+export const removePopups = async (): Promise<void> => {
+  const windows = await chrome.windows.getAll();
+  windows.forEach((window) => {
+    if (window.type === 'popup' && window.id) {
+      chrome.windows.remove(window.id);
+    }
+  });
+};
+
 export const checkEstablished = async (
   requestData: InjectionMessage,
   sendResponse: (response: any) => void,