Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: close pool #53

Merged
merged 3 commits into from
Jun 11, 2024
Merged

test: close pool #53

merged 3 commits into from
Jun 11, 2024

Conversation

gosuto-inzasheru
Copy link
Contributor

closes #52

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (41469f3) to head (3e9b560).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   82.14%   88.77%   +6.63%     
==========================================
  Files           3        3              
  Lines         196      196              
  Branches       21       21              
==========================================
+ Hits          161      174      +13     
+ Misses         31       21      -10     
+ Partials        4        1       -3     

see 1 file with indirect coverage changes

@gosuto-inzasheru
Copy link
Contributor Author

coverage should now be 100% after foundry-rs/foundry#4553 is solved

Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice flow in the pool close test file 🔥

checks properly that bpt after EXEC_QUEUE_POOL_ACTION being exec the bpt balance in the card is 0 ✅

@gosuto-inzasheru gosuto-inzasheru merged commit 0c11ba3 into main Jun 11, 2024
2 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the issue/52 branch June 11, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: cover _poolClose
2 participants