Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests using custom-components/integration_blueprint#50 as base #112
Add tests using custom-components/integration_blueprint#50 as base #112
Changes from 14 commits
c6c532b
703a73c
d5a79d5
79befed
959fd4c
750ef81
447bf25
58189bb
5bf4305
acaf8e1
fcb2bb1
4df79ea
52dcc02
28fcd1b
fee37a3
b1bd9d8
f3942bc
1a40ce0
3755c8c
b4bfe05
9e0c955
1b13516
2a5495b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the objective of this test can you explain me ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We call the function directly so that we can test any logic that exists within the function (in this case there is none). Since we don't want to actually fetch data, we are using
aioclient_mock
to set up a mock return value for a patch to the URL, which is whatasync_set_title
does under the hood.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments that hopefully help, let me know what you think.