Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataFrameWriter related stuff #24

Open
wants to merge 3 commits into
base: sql-dataframe
Choose a base branch
from

Conversation

tomz
Copy link

@tomz tomz commented Nov 22, 2015

Tried some examples, working so far, and came across a typo in DataFrame#limit

@tomz tomz changed the title Correct typo in #limit Add DataFrameWriter related stuff Dec 17, 2015
@ondra-m
Copy link
Owner

ondra-m commented Dec 23, 2015

Sorry for delay :)

  1. Use brackets for method parameters

    def sql query
    # =>
    def sql(query)
  2. Please write some tests

@ondra-m ondra-m assigned ondra-m and unassigned ondra-m Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants