fix(charts): simplify minio secret handling

one-acre-fund · Nov 11, 2024 · f0836c1 · f0836c1
1 parent a4d23e4
commit f0836c1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/charts/nocodb/Chart.yaml b/charts/nocodb/Chart.yaml
@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.4.2
+version: 0.4.3
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

diff --git a/charts/nocodb/README.md b/charts/nocodb/README.md
@@ -1,6 +1,6 @@
 # nocodb
 
-![Version: 0.4.2](https://img.shields.io/badge/Version-0.4.2-informational?style=flat-square) 
+![Version: 0.4.3](https://img.shields.io/badge/Version-0.4.3-informational?style=flat-square) 
 ![AppVersion: 0.257.2](https://img.shields.io/badge/AppVersion-0.257.2-informational?style=flat-square) 
 
 A Helm chart for Kubernetes

diff --git a/charts/nocodb/templates/_helpers.tpl b/charts/nocodb/templates/_helpers.tpl
@@ -212,11 +212,7 @@ Add environment variables to configure database values
 Get the credentials secret.
 */}}
 {{- define "nocodb.minio.secretName" -}}
-{{- if .Values.minio.auth.existingSecret -}}
-    {{- printf "%s" (tpl .Values.minio.auth.existingSecret $) -}}
-{{- else -}}
-    {{- printf "%s" (include "nocodb.minio.fullname" .) -}}
-{{- end -}}
+{{- coalesce .Values.minio.auth.existingSecret .Values.externalMinio.existingSecret (include "nocodb.minio.fullname" .) -}}
 {{- end -}}
 
 {{- define "nocodb.minio.rootUserKey" -}}