feat(deployment): add init containers to wait for Minio and Redis readiness #209
+36
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the Helm chart for NocoDB, primarily focusing on version updates and enhancements to the deployment process. The most important changes include updating the chart version, adding init containers for Minio and Redis, and updating the README to reflect the new version.
Version Updates:
charts/nocodb/Chart.yaml: Updated the chart version from0.4.1to0.4.2.charts/nocodb/README.md: Updated the version badge from0.4.1to0.4.2.Deployment Enhancements:
charts/nocodb/templates/deployment.yaml: Added init containers to wait for Minio and Redis services to be ready before starting the main application container.charts/nocodb/templates/deployment.yaml: Adjusted the existing init container logic for waiting on the database to be conditional based on configuration values.