Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bestpractices.md #106

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Update bestpractices.md #106

merged 1 commit into from
Mar 4, 2020

Conversation

mjkoster
Copy link
Contributor

Add text conventions for identifier spelling style

@mjkoster
Update bestpractices.md
8bf5ad4 
Add text conventions for identifier spelling style
@mjkoster mjkoster added documentation Improvements or additions to documentation Best Practices labels Feb 27, 2020
@mjkoster mjkoster self-assigned this Feb 27, 2020
@mjkoster mjkoster mentioned this pull request Feb 27, 2020
Open
@mjkoster
Copy link
Contributor Author

mjkoster commented Feb 27, 2020 •
edited
Loading

Addresses this issue: #97

akeranen
akeranen approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@akeranen akeranen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many ecosystems prefer snake_case naming, but being here consistent with JSON schema naming conventions seems to make sense.

@mjkoster mjkoster merged commit b876c2b into master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akeranen akeranen akeranen approved these changes

@WAvdBeek WAvdBeek WAvdBeek approved these changes

Assignees

@mjkoster mjkoster

Labels
Best Practices documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjkoster @akeranen @WAvdBeek