Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCLomatic] Add test for migration of thrust::device_reference type #122

Merged
merged 1 commit into from
Nov 9, 2022
Merged

[SYCLomatic] Add test for migration of thrust::device_reference type #122

merged 1 commit into from
Nov 9, 2022

Conversation

jzc
Copy link
Contributor

@jzc jzc commented Oct 21, 2022

Test for: oneapi-src/SYCLomatic#319

Signed-off-by: Cai, Justin justin.cai@intel.com

@jzc
[SYCLomatic] Add test for migration of thrust::device_reference type
85bf462 
Signed-off-by: Cai, Justin <justin.cai@intel.com>
@jzc jzc requested a review from a team as a code owner October 21, 2022 23:21
tomflinda
tomflinda approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhimingwang36
zhimingwang36 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@zhimingwang36 zhimingwang36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhimingwang36 zhimingwang36 merged commit a411e25 into oneapi-src:SYCLomatic Nov 9, 2022
zhimingwang36 added a commit that referenced this pull request Nov 9, 2022
@zhimingwang36
Revert "[SYCLomatic #319] Add test for migration of thrust::device_re…
c8933d5 
…ference type (#122)"

This reverts commit a411e25.
@zhimingwang36 zhimingwang36 mentioned this pull request Nov 9, 2022
Merged
zhimingwang36 added a commit that referenced this pull request Nov 9, 2022
@zhimingwang36
Revert "[SYCLomatic #319] Add test for migration of thrust::device_re…
8eec9bf 
…ference type (#122)" (#134)

This reverts commit a411e25.
@jzc jzc deleted the device_reference branch November 9, 2022 16:50
@jzc jzc restored the device_reference branch November 9, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomflinda tomflinda tomflinda approved these changes

@zhimingwang36 zhimingwang36 zhimingwang36 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzc @tomflinda @zhimingwang36