[SYCLomatic] Remove invalid json test for standard compilation db fields #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed, Daiyaan <daiyaan.ahmed@intel.com>
daiyaan-ahmed6
force-pushed
the
remove_invalid_json_test
branch
from
4d43101
to
7c376c5
Compare
tomflinda
reviewed
Jan 8, 2024
| if "directory_placeholder" in line: | ||
| ret.append(" \"output\": \"aaaaa\",\n") | ||
| line = line.replace("directory_placeholder", os.getcwd().replace("\\", "\\\\")) | ||
| iter += 1 |
There was a problem hiding this comment.
Sine 'Output' and 'Arguments' in compile_commands.json could be consumed by SYCLomatic, the test case should keep 'output' in compile_commands.json and also added 'Arguments' to verify this feature, instead of remove them.
There was a problem hiding this comment.
In the new PR for this, I have changed the name of these tests to 'standard_compilation_db_json' and I am keeping 'Arguments' and 'Output' in compilation db to verify that dpct consumes these arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed tests are check for 'Output' and 'Arguments' field in dpct to be invalid.
This is done for passing of feature PR: oneapi-src/SYCLomatic#1566
ngt-invalid-json7 and ngt-invalid-json8 test are removed.
ngt-invalid-json9 and ngt-invalid-json10 are renamed to ngt-invalid-json7 and ngt-invalid-json8 respectively.
Signed-off-by: Daiyaan Ahmed daiyaan.ahmed@intel.com