-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating description for MatchMode in Migration Rules #2390
Conversation
… Migration Rules"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- ``Partial`` | ``Full`` | ||
- Required. Specify the match mode with full word match or partial word match. If not specified, partial match mode will be used. | ||
- ``Partial`` | ``Full`` | ``StrictFull`` | ||
- Optional. Specify the match mode with full word match, strict full word match, or partial word match. If not specified, partial match mode will be used. The partial matching mode means the matching string can be surrounded by arbitrary characters including whitespace. The full matching mode means the matching string can only be surrounded by non-identifier characters (letters, numbers and underscore). The strict matching mode means the matching string can only be surrounded by whitespace characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomflinda , please update the the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
- ``Partial`` | ``Full`` | ||
- Required. Specify the match mode with full word match or partial word match. If not specified, partial match mode will be used. | ||
- ``Partial`` | ``Full`` | ``StrictFull`` | ||
- Optional. Specify the match mode with full word match, strict full word match, or partial word match. If not specified, partial match mode will be used. The partial matching mode means the matching string can be surrounded by arbitrary characters including whitespace. The full matching mode means the matching string can only be surrounded by non-identifier characters (letters, numbers and underscore). The strict matching mode means the matching string can only be surrounded by whitespace characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls update the sub string:
The partial matching mode means the matching string can be surrounded by arbitrary characters including whitespace. The full matching mode means the matching string can only be surrounded by non-identifier characters (letters, numbers and underscore). The strict matching mode means the matching string can only be surrounded by whitespace characters.
to
The partial matching mode means the matched string can be surrounded by arbitrary characters including whitespace. The full matching mode means the matched string should not be surrounded by identifier characters (letters, numbers, and underscore). The strict matching mode means the matched string should only be surrounded by whitespace characters.
For https://jira.devtools.intel.com/browse/DOC-12840