Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCLomatic] Remove -fgpu-exclude-wrong-side-overloads to avoid other parsing errors #2662

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

zhiweij1
Copy link
Contributor

This option was added to fix one parsing error.
But now we found it introduced other errors.
So in the PR, we remove it and choose another way to fix the previous issue.

Signed-off-by: Jiang, Zhiwei zhiwei.jiang@intel.com

Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
…her parsing errors

Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
@zhiweij1 zhiweij1 requested a review from a team as a code owner February 13, 2025 05:00
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
@zhimingwang36 zhimingwang36 merged commit 6268df4 into oneapi-src:SYCLomatic Feb 19, 2025
3 of 7 checks passed
@zhiweij1 zhiweij1 deleted the fix_parsing_issue branch February 19, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants