-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove time units for activeTime and timestamp fields #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandres742
reviewed
Sep 1, 2023
joshuaranjan
reviewed
Sep 2, 2023
6ce399d
to
bb343cb
Compare
lgtm |
I think “implementation specific” is better. Obfuscation is not a meaning any spec should convey. Another term that might work OK here is “opaque”, but "implementation specific" is preferable. It allows for the most flexibility in terms of implementation, while informing the user that the type or representation of some object or metric is purposefully opaque for their purposes.
________________________________
From: Jaime Arteaga ***@***.***>
Sent: Tuesday, September 19, 2023 6:52:54 PM
To: oneapi-src/level-zero-spec ***@***.***>
Cc: Damon, Will ***@***.***>; Mention ***@***.***>
Subject: Re: [oneapi-src/level-zero-spec] Remove time units for activeTime and timestamp fields (PR #208)
@jandres742 commented on this pull request.
________________________________
In scripts/sysman/engine.yml<#208 (comment)>:
@@ -69,11 +69,13 @@ name: $s_engine_stats_t
members:
- type: uint64_t
name: "activeTime"
- desc: "[out] Monotonic counter for time in microseconds that this resource is actively running workloads."
+ desc: |
+ [out] Monotonic counter where the resource is actively running workloads.
in terms of specifications, "implementation specific" is more used than "obfuscated". Basically what we are saying is that user shouldn't assume anything about the time units.
@wdamon-intel<https://github.com/wdamon-intel> : what do you think?
—
Reply to this email directly, view it on GitHub<#208 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A25YXTICFH7OFACSUK6JVO3X3IO4NANCNFSM6AAAAAA4H67J3U>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
bb343cb
to
20c9fd6
Compare
Addresses oneapi-src#197 Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@intel.com>
joshuaranjan
approved these changes
Oct 6, 2023
jandres742
approved these changes
Oct 6, 2023
wdamon-intel
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #197