Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the lxml version requirement to 4.9.1 #31

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

wdamon-intel
Copy link
Contributor

Requirements failed to install due to stale lxml version; updating to 4.9.1.

@jandres742
Copy link

thanks @wdamon-intel ! question, why do we need 4.9.1? latest available in Ubuntu from official repo is 4.5.0
https://packages.ubuntu.com/search?keywords=python-lxml

while on suse 15.4 is 4.7.1
https://software.opensuse.org/package/python-lxml

do we need something specific from 4.9.1 or is just that you used latest from https://lxml.de/installation.html?

@wdamon-intel
Copy link
Contributor Author

wdamon-intel commented Oct 26, 2022 via email

@jandres742
Copy link

thanks @wdamon-intel . Do you think it would be possible to post the PR with 4.5.0, just to require what is already available in the official repos?

@wdamon-intel
Copy link
Contributor Author

@jandres742 4.5.0 fails to build with the same error as 4.4.2. 4.7.1 works OK on Ubuntu, but why not move to the current release?

@jandres742
Copy link

thanks @wdamon-intel . Which error do you see, could you share?

4.9.1 is latest release from source, but not from available official repos, so I'm just trying to see how to minimize burden on users forcing them to install dependencies that are not coming in the official repos.

@wdamon-intel
Copy link
Contributor Author

@jandres742 Here is an example from Windows, though Linux issues a similar error for a different file (libxml/xmlversion.h).

C:\Users\<username>\AppData\Local\Temp\xmlXPathInitsrt1nyno.c(1): fatal error C1083: Cannot open include file: 'libxml/xpath.h': No such file or directory
      error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Professional\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX86\\x64\\cl.exe' failed with exit code 2
      *********************************************************************************
      Could not find function xmlCheckVersion in library libxml2. Is libxml2 installed?
      *********************************************************************************
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> lxml

note: This is an issue with the package mentioned above, not pip.

@jandres742
Copy link

thanks @wdamon-intel . ok, let's merge it. I tested it on my side on Linux w/o any issues.

@jandres742 jandres742 merged commit 79989c7 into oneapi-src:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants