third_party: ngen: add movi src check #2471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kealan-barbieri
added
the
platform:gpu-intel
github-actions
bot
removed
the
platform:gpu-intel
petercad
approved these changes
Jan 22, 2025
petercad
reviewed
Jan 22, 2025
third_party/ngen/ngen.hpp
Outdated
| @@ -1947,6 +1947,9 @@ BinaryCodeGenerator<hw>::opX(Opcode op, DataType defaultType, const InstructionM | |||
|
|
|||
| typename EncodingTag12Dispatch<hw>::tag tag; | |||
| Instruction12 i{}; | |||
| #ifdef NGEN_SAFE | |||
| if (!src0.isIndirect()) throw grf_expected_exception(); | |||
There was a problem hiding this comment.
grf_expected_exception doesn't have quite the right message for this situation... feel free to add a new exception type in ngen_core.hpp.
There was a problem hiding this comment.
added invalid_address_mode_exception, thanks!
kealan-barbieri
force-pushed
the
kealanba/misc_fixes
branch
from
28a906b to
f3ceb3d
Compare
atkassen
reviewed
Jan 23, 2025
kealan-barbieri
force-pushed
the
kealanba/misc_fixes
branch
from
1348a74 to
30603e7
Compare
kealan-barbieri
force-pushed
the
kealanba/misc_fixes
branch
from
30603e7 to
6a4c000
Compare
rjoursler
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check that
movisrc is indirect as required.Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?