gpu: quantization refactoring prerequisites #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares gemm_with_post_ops for `data_type::undef` in scales data types and also a custom data type in dst scales.
github-actions
bot
added
the
platform:gpu-intel
|
make test |
rjoursler
approved these changes
Jan 24, 2025
echeresh
approved these changes
Jan 24, 2025
dzarukin
force-pushed
the
dzarukin/refactor_quant_prereq
branch
from
ca82718 to
d7c52ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates gemm_with_post_ops implementation with a new way of loading scales as they are going to be affected after refactor. The main issue is that
data_type::undefbecomes a valid data type for scales, meaning, they were not specified, which would trigger a bunch of issues in the existing implementation.This PR guards from that situation.
Thanks to @rjoursler for a patch to deal with undefined data types.