Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake diagnostics of the used backend #959

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

dmitriy-sobolev
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev commented May 22, 2023

This fixes an issue when cmake provides wrong information on the used backend.

It happens when all the conditions are satisfied:

  • The compiler supports -fsycl feature
  • SYCL headers are not available
  • ONEDPL_BACKEND is equal to dpcpp or dpcpp_only or not explicitly provided.

In that case, cmake prints a message that DPCPP backend is going to be used, but oneDPL headers do not enable it, because SYCL headers are not available.

Examples of such compilers: Clang++ v13, v14.

Signed-off-by: Dmitriy Sobolev <dmitriy.sobolev@intel.com>
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
As a confirmation this feature (CHECK_INCLUDE_FILE_CXX) and the way we use it is available for CMake 3.11, so this does not impact our minimum CMake version requirements.

@dmitriy-sobolev
Copy link
Contributor Author

I am going to merge it after the next release in order not to bring more risks.

@dmitriy-sobolev dmitriy-sobolev merged commit 5087628 into main Jun 22, 2023
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/cmake-sycl-fix branch June 22, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants