Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce MAINTAINERS.md #1560

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
+143 −0
Open

Introduce MAINTAINERS.md #1560

Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
71a60d2
Initial commit
pavelkumbrasev Nov 8, 2024
1109f38
Add table with responsibilities and privileges
pavelkumbrasev Nov 13, 2024
7963ed6
Fix aligment of the table and remove colors
pavelkumbrasev Nov 13, 2024
a715f1a
Remove color
pavelkumbrasev Nov 14, 2024
ca4d538
Apply suggestions from code review
pavelkumbrasev Nov 19, 2024
50993de
Update document
pavelkumbrasev Nov 19, 2024
851ec85
Apply suggestions from code review
pavelkumbrasev Nov 19, 2024
71fb5e4
Apply review comments
pavelkumbrasev Nov 19, 2024
91285d6
Apply review comments
pavelkumbrasev Nov 19, 2024
25318ac
Apply review comments
pavelkumbrasev Nov 20, 2024
bb934c4
Apply review comments
pavelkumbrasev Nov 20, 2024
7f20b96
Apply suggestions from code review
pavelkumbrasev Nov 21, 2024
2a51127
Apply review comments
pavelkumbrasev Nov 21, 2024
d1e49a1
Update the table
pavelkumbrasev Nov 21, 2024
45ccb8f
Update MAINTAINERS.md
pavelkumbrasev Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions MAINTAINERS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

This document defines roles in the oneTBB project.

# Roles and responsibilities
# Roles and Responsibilities

oneTBB project defines three main roles:
* [Contributor](#contributor)
Expand All @@ -30,11 +30,11 @@ oneTBB project defines three main roles:
| | Contributor | Code Owner | Maintainer |
| :------------------------------------------------------------------------------------------------------------------------------------------ | :---------------------: | :---------------------: | :---------------------: |
| _Responsibilities_ | | | |
| Follow the Code of Conduct | ✓ | ✓ | ✓ |
| Follow Contribution Guidelines | ✓ | ✓ | ✓ |
| Enforce Contribution Guidelines | ✗ | ✓ | ✓ |
| Follow the [Code of Conduct](./CODE_OF_CONDUCT.md) | ✓ | ✓ | ✓ |
| Follow [Contribution Guidelines](./CONTRIBUTING.md) | ✓ | ✓ | ✓ |
| Insure [Contribution Guidelines](./CONTRIBUTING.md) are followed | ✗ | ✓ | ✓ |
pavelkumbrasev marked this conversation as resolved.
Show resolved Hide resolved
| Co-own component or aspect of the library,<br> including contributing: bug fixes, implementing features,<br> and performance optimizations | ✗ | ✓ | ✓ |
| Co-own on technical direction of component or<br> aspect of the library | ✗ | ✗ | ✓ |
| Co-own on technical direction of component or<br> aspect of the library including work on RFCs | ✗ | ✓ | ✓ |
| Co-own the project as a whole,<br> including determining strategy and policy for the project | ✗ | ✗ | ✓ |
| _Privileges_ | | | |
| Permission granted | [Read][permissions] | [Write][permissions] | [Maintain][permissions] |
Expand All @@ -43,7 +43,7 @@ oneTBB project defines three main roles:
| Can participate in promotions of<br> Code Owners and Maintainers | ✗ | ✗ | ✓ |
| Can suggest Milestones during planning | ✓ | ✓ | ✓ |
| Can choose Milestones for specific component | ✗ | ✓ | ✓ |
| Choose project's Milestones during planning | ✗ | ✗ | ✓ |
| Make a decision on project's Milestones during planning | ✗ | ✗ | ✓ |
| Can propose new RFC or<br> participate in review of existing RFC | ✓ | ✓ | ✓ |
| Can request rework of RFCs<br> in represented area of responsibility | ✗ | ✓ | ✓ |
| Can request rework of RFCs<br> in any part of the project | ✗ | ✗ | ✓ |
Expand All @@ -56,7 +56,7 @@ requirements and the nomination process.
## Contributor

A Contributor invests time and resources to improve oneTBB project.
Anyone can become a Contributor by bringing value in one of the following ways:
Anyone can become a Contributor by bringing value in any following way:
* Answer questions from community members.
* Propose changes to the design.
* Provide feedback on design proposals.
Expand All @@ -68,37 +68,37 @@ and performance optimizations.
## Code Owner

A Code Owner has responsibility for a specific project component or a functional
area. Code Owners are collectively responsible, with other Code Owners,
area. Code Owners are collectively responsible
for developing and maintaining their component or functional areas, including
reviewing all changes to corresponding areas of responsibility and indicating
whether those changes are ready to be merged. Code Owners have a track record of
contribution and review in the project.

Requirements:
**Requirements:**
* Track record of accepted code contributions to a specific project component.
* Track record of contributions to the code review process.
* Demonstrated in-depth knowledge of the architecture of a specific project
* Demonstrate in-depth knowledge of the architecture of a specific project
component.
* Commits to being responsible for that specific area.
* Commit to being responsible for that specific area.

The process of becoming a Code Owner is:
How to become a Code Owner?
1. A Contributor is nominated by opening a PR modifying the MAINTAINERS.md file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a contributor nominate themselves?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a contributor nominate themselves?

I think it is acceptable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure.

including name, Github username, and affiliation.
2. At least two specific component Maintainers approve the PR.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, there is only one Maintainer right now in oneTBB Core component, for example. How is it possible for "at least two" Maintainers to ACK such PR? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it states earlier that Code Owners "participate in promotions of Code Owners", how do they participate if that cannot approve these. I think maybe "specific component Maintainer" -> "Code Owners of that component or Maintainers"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an error, code-owners cannot participate in promotion process

3. CODEOWNERS file is updated to represent corresponding areas of responsibility.
3. [CODEOWNERS](./CODEOWNERS) file is updated to represent corresponding areas of responsibility.

## Maintainer
Maintainers are the most established contributors who are responsible for the
project technical direction and participate in making decisions about the
Maintainers are the most established contributors responsible for the
project technical direction. They participate in making decisions about the
strategy and priorities of the project.

Requirements:
* Experience as a Code Owner.
**Requirements:**
* Have experience as a Code Owner.
* Track record of major project contributions to a specific project component.
* Demonstrated deep knowledge of a specific project component.
* Demonstrated broad knowledge of the project across multiple areas.
* Commits to using privileges responsibly for the good of the project.
* Is able to exercise judgment for the good of the project, independent of
* Demonstrate deep knowledge of a specific project component.
* Demonstrate broad knowledge of the project across multiple areas.
* Commit to using privileges responsibly for the good of the project.
* Be able to exercise judgment for the good of the project, independent of
their employer, friends, or team.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how it can be measured though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, maintainer would need to present proofs.
I'm not sure how to measure this :)


Process of becoming a maintainer:
Expand All @@ -112,14 +112,14 @@ opening a PR against MAINTAINERS.md file.

| Name | Github ID | Affiliation | Role |
| --------------------- | --------------------- | ----------------- | ---------- |
| Konstantin Boyarinov | @kboyarinov | Intel Corporation | Code Owner |
| Aleksei Fedotov | @aleksei-fedotov | Intel Corporation | Code Owner |
| Ilya Isaev | @isaevil | Intel Corporation | Code Owner |
| Sarath Nandu R | @sarathnandu | Intel Corporation | Code Owner |
| Dmitri Mokhov | @dnmokhov | Intel Corporation | Code Owner |
| Michael Voss | @vossmjp | Intel Corporation | Maintainer |
| Alexey Kukanov | @akukanov | Intel Corporation | Code Owner |
| Pavel Kumbrasev | @pavelkumbrasev | Intel Corporation | Code Owner |
| Konstantin Boyarinov | @kboyarinov | Intel Corporation | Maintainer |
| Aleksei Fedotov | @aleksei-fedotov | Intel Corporation | Maintainer |
| Michael Voss | @vossmjp | Intel Corporation | Maintainer |
| Pavel Kumbrasev | @pavelkumbrasev | Intel Corporation | Maintainer |

## oneTBB TBBMALLOC (API, Architecture, Tests)

Expand All @@ -135,7 +135,7 @@ opening a PR against MAINTAINERS.md file.
| Alexandra Epanchinzeva | @aepanchi | Intel Corporation | Code Owner |


## oneTBB Release management
## oneTBB Release Management

| Name | Github ID | Affiliation | Role |
| ------------------ | --------------------- | ----------------- | ---------- |
Expand Down
Loading