Fix crash in urAdapterGet with non-initialized platforms

Encountered in a bothched ASAN build, but makes sense to check platform status before trying to query it.
oneapi-src · Apr 22, 2024 · 200e628 · 200e628
1 parent 717791b
commit 200e628
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/scripts/templates/ldrddi.cpp.mako b/scripts/templates/ldrddi.cpp.mako
@@ -58,6 +58,8 @@ namespace ur_loader
         {
             for( auto& platform : context->platforms )
             {
+                if(platform.initStatus != ${X}_RESULT_SUCCESS)
+                    continue;
                 platform.dditable.${n}.${th.get_table_name(n, tags, obj)}.${th.make_pfn_name(n, tags, obj)}( 1, &${obj['params'][1]['name']}[adapterIndex], nullptr );
                 try
                 {

diff --git a/source/loader/ur_ldrddi.cpp b/source/loader/ur_ldrddi.cpp
@@ -54,6 +54,9 @@ __urdlllocal ur_result_t UR_APICALL urAdapterGet(
     size_t adapterIndex = 0;
     if (nullptr != phAdapters && NumEntries != 0) {
         for (auto &platform : context->platforms) {
+            if (platform.initStatus != UR_RESULT_SUCCESS) {
+                continue;
+            }
             platform.dditable.ur.Global.pfnAdapterGet(
                 1, &phAdapters[adapterIndex], nullptr);
             try {